Skip to content

fix: allow resolve API to handle non-standard Python executable names (Fixes #375)#376

Merged
karthiknadig merged 2 commits intomainfrom
fix/issue-375
Mar 19, 2026
Merged

fix: allow resolve API to handle non-standard Python executable names (Fixes #375)#376
karthiknadig merged 2 commits intomainfrom
fix/issue-375

Conversation

@karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Mar 16, 2026 •
edited
Loading

Removes the is_python_executable_name guard from resolve_environment() so that non-standard Python executable names (e.g., mayapy.exe, hython.exe) are not rejected when explicitly provided via the resolve API.

  • The name check in find_executables() (directory scanning) is preserved for performance
  • The resolve path now trusts the caller-provided executable and attempts locator identification + spawning regardless of filename
  • Added tests verifying non-standard names reach the locator chain
  • Added documentation tests for DCC tool executable names (mayapy, hython, bpy)

Fixes #375

@github-actions
Copy link

github-actions bot commented Mar 16, 2026 •
edited
Loading

Test Coverage Report (Linux)

Metric Value
Current Coverage 64.3%
Base Branch Coverage 64.1%
Delta .2% ✅

Coverage increased! Great work!

@github-actions
Copy link

github-actions bot commented Mar 16, 2026 •
edited
Loading

Performance Report (Linux) ➖

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 1ms 1ms 1ms 0ms 0%
Full Refresh 97ms 438ms 95ms 2ms 0%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Mar 16, 2026 •
edited
Loading

Performance Report (Windows) ✅

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 9ms 12ms 13ms -4ms -30.8%
Full Refresh 165ms 5343ms 224ms -59ms -26.3%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Mar 16, 2026 •
edited
Loading

Test Coverage Report (Windows)

Metric Value
Current Coverage 60.41%
Base Branch Coverage 60.21%
Delta 0.2% ✅

Coverage increased! Great work!

@github-actions
Copy link

github-actions bot commented Mar 16, 2026 •
edited
Loading

Performance Report (macOS)

Metric PR (P50) PR (P95) Baseline (P50) Delta
Server Startup 84ms 679ms 52ms 32ms
Full Refresh 142ms 38251ms 93ms 49ms

Results based on 10 iterations. P50 = median, P95 = 95th percentile.

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@karthiknadig karthiknadig marked this pull request as ready for review March 17, 2026 03:00
@karthiknadig karthiknadig enabled auto-merge (squash) March 17, 2026 03:00
@vs-code-engineering vs-code-engineering bot added this to the 1.112.0 milestone Mar 17, 2026
@karthiknadig karthiknadig merged commit b8bff92 into main Mar 19, 2026
30 checks passed
@karthiknadig karthiknadig deleted the fix/issue-375 branch March 19, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eleanorjboyd eleanorjboyd eleanorjboyd approved these changes

Assignees

@karthiknadig karthiknadig

Labels

None yet

Projects

None yet

Milestone

1.112.0

Development

Successfully merging this pull request may close these issues.

Unable to use name changed Embedded Python Interpreters due to Python Name Check

2 participants

@karthiknadig @eleanorjboyd